Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate block production from Tendermint #171

Closed
kayabaNerve opened this issue Nov 29, 2022 · 0 comments
Closed

Separate block production from Tendermint #171

kayabaNerve opened this issue Nov 29, 2022 · 0 comments
Labels
discussion This requires discussion tendermint

Comments

@kayabaNerve
Copy link
Member

Tendermint does designate a specific proposer and can never fully align with Substrate's separated view. What Tendermint can do is redefine the proposal from a locally built block to a hash of a (externally) proposed block. It'd reduce the scope of Tendermint, may help with #137, and may offer more functionality than previously imagined.

This doesn't solve problems with Tendermint such as #134. Even if we use BABE for production, there'd still be a single proposer for which of the proposed blocks to use. We also can't fully remove block production from Tendermint as we set the best chain to be the finalized one, not the longest one (which other libs may expose?).

This may not be worth it or may be. Tracking issue to explain it and enable consideration.

@kayabaNerve kayabaNerve added discussion This requires discussion tendermint labels Nov 29, 2022
kayabaNerve added a commit that referenced this issue Mar 26, 2023
Updates to polkadot-v0.9.40, with a variety of dependency updates accordingly.
Substrate thankfully now uses k256 0.13, pathing the way for #256. We couldn't
upgrade to polkadot-v0.9.40 without this due to polkadot-v0.9.40 having
fundamental changes to syncing. While we could've updated tendermint, it's not
worth the continued development effort given its inability to work with
multiple validator sets.

Purges sc-tendermint. Keeps tendermint-machine for #163.

Closes #137, #148, #157, #171. #96 and #99 should be re-scoped/clarified. #134
and #159 also should be clarified. #169 is also no longer a priority since
we're only considering temporal deployments of tendermint. #170 also isn't
since we're looking at effectively sharded validator sets, so there should
be no singular large set needing high performance.
@kayabaNerve kayabaNerve closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This requires discussion tendermint
Projects
None yet
Development

No branches or pull requests

1 participant