-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #982 Enable developers to customize the "/slack/install" webpage content #1
base: issue-977-slack-install-flag
Are you sure you want to change the base?
Fix #982 Enable developers to customize the "/slack/install" webpage content #1
Conversation
Codecov Report
@@ Coverage Diff @@
## issue-977-slack-install-flag #1 +/- ##
===============================================================
Coverage ? 70.70%
===============================================================
Files ? 13
Lines ? 1222
Branches ? 363
===============================================================
Hits ? 864
Misses ? 286
Partials ? 72 Continue to review full report at Codecov.
|
…r to ExpressReceiver (slackapi#1084)
…iver: Receiver arguments in App constructor (slackapi#1077) * Fix slackapi#1068 Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor * Update src/App.ts
…/install" (slackapi#1079) * Fix slackapi#977 Add a way to turn off web page rendering for "/slack/install" * Remove package-lock.json from the example app * Apply suggestions from code review Co-authored-by: Fil Maj <[email protected]> * Add bolt to dependencies * Comment out the new flag in the example app * Rename directInstallUrlEnabled to directInstall * Apply suggestions from code review Co-authored-by: Sarah Jiang <[email protected]> Co-authored-by: Fil Maj <[email protected]> Co-authored-by: Sarah Jiang <[email protected]>
4bbbd19
to
b5938e6
Compare
…for invoking the installRedirectHandler
Update code to fix TS v.4.4 compiler errors
…oving fully to eslint from tslint. All of these changes are courtesy of @aoberoi and the work they put into slackapi#669 🙇
…d using snake_case
…tead. Dedupe some copy-pasted test helpers from AwsReceiver spec. Move a linter ignore directive from tslint to eslint.
…naming conventions.
… = operator, and prefix for other operators to be at the end of the line.
…irectories to import submodules from.
…s the use of short-circuit logical operators (|| and &&).
Allow use of "as Type" syntax for type assertions in test code. Dont force symbol descriptors in test code
…he accessibility of constructors for various classes.
…webpage content
a59e189
to
ac6b5bb
Compare
Summary
This pull request fixes slackapi#982 by adding a new function argument to customize the HTML content renderer for
/slack/install
URL.Requirements (place an
x
in each[ ]
)