This repository has been archived by the owner on May 6, 2020. It is now read-only.
fix(rustup): 1.2.0 (7cb9914fc 2015-05-25) #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted method signatures to deal with the recently added `Constness` flag. For now it just defaults to `NotConst` which seems a reasonable default. However, I must admit I have no idea what I was doing, except to make builds work with the latest nightly (also with `cargo test`). Unfortunately, this makes the code incompatible with stable, which could probably be considered a problem. This PR might just be a hint and for others to see in case they have the same problems ... and I wouldn't consider it an actual fix. As a last note: even though this compiles on a recent nightly, in case you want to use `serde_macros`, these will not work due to other issues that are beyond my fixing capabilities.
|
Just landed this in another patch. Thanks though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted method signatures to deal with the recently added
Constnessflag.
For now it just defaults to
NotConstwhich seems a reasonable default.However, I must admit I have no idea what I was doing, except to make
builds work with the latest nightly (also with
cargo test).Unfortunately, this makes the code incompatible with stable, which could
probably be considered a problem.
This PR might just be a hint and for others to see in case they have
the same problems ... and I wouldn't consider it an actual fix.
As a last note: even though this compiles on a recent nightly, in case
you want to use
serde_macros, these will not work due to other issuesthat are beyond my fixing capabilities.