Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update de.rs #1065

Closed
wants to merge 1 commit into from
Closed

Update de.rs #1065

wants to merge 1 commit into from

Conversation

jans2002
Copy link

@jans2002 jans2002 commented Sep 6, 2023

Support de-serialize Option element in JSON data like [,,value] # # #1064

@jans2002
Update de.rs
e9af602 
Support de-serialize  Option element in tuple struct
dtolnay
dtolnay requested changes Sep 6, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

[,,value] is not valid JSON. I would not expect serde_json to successfully deserialize it.

@jans2002
Copy link
Author

jans2002 commented Sep 7, 2023

Yes, you're right. I am mislead because it can be parsed when it is manually inputed in NodeJS. I just want to cancel the PR.

@jans2002 jans2002 closed this Sep 7, 2023
@jans2002 jans2002 deleted the patch-1 branch September 7, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jans2002 @dtolnay