-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant ctx or user_data fields #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnomedDev
force-pushed
the
remove-redundant-fields
branch
from
January 16, 2024 20:54
caabada
to
acfb91b
Compare
Closed
GnomedDev
added a commit
that referenced
this pull request
Jan 23, 2024
GnomedDev
added a commit
that referenced
this pull request
Jan 24, 2024
GnomedDev
added a commit
that referenced
this pull request
Apr 11, 2024
GnomedDev
added a commit
to GnomedDev/poise
that referenced
this pull request
Apr 14, 2024
GnomedDev
added a commit
to NotNorom/poise
that referenced
this pull request
May 3, 2024
GnomedDev
added a commit
that referenced
this pull request
May 23, 2024
GnomedDev
added a commit
that referenced
this pull request
May 23, 2024
tazz4843
pushed a commit
to tazz4843/poise
that referenced
this pull request
Jun 9, 2024
GnomedDev
added a commit
that referenced
this pull request
Oct 19, 2024
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
GnomedDev
added a commit
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes redundant serenity::Context references or user_data references where they could be accessed some other way. This was set as a TODO in multiple places.