Swap Command and related structs to avoid String allocs #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbt365
approved these changes
Nov 13, 2024
GnomedDev
force-pushed
the
cow-command
branch
from
76a0b68
to
b9358a5
Compare
GnomedDev
force-pushed
the
cow-command
branch
from
b9358a5
to
3b50409
Compare
GnomedDev
added a commit
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids allocating a bunch of
Strings andVecs when they can just be literals. This significantly simplifies command construction functions towards the goal of making themstatic, or close to at least.This does not impact modifying these values at runtime as
Cow<'static, str>can storeStringas well as&'static str.