Remove help commands from built-ins #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnomedDev
force-pushed
the
remove-help-builtins
branch
from
abf8c48
to
6553c5d
Compare
8 tasks
jamesbt365
approved these changes
Nov 13, 2024
GnomedDev
force-pushed
the
remove-help-builtins
branch
from
6553c5d
to
0b20ec2
Compare
GnomedDev
force-pushed
the
remove-help-builtins
branch
from
0b20ec2
to
ea4a30f
Compare
GnomedDev
added a commit
that referenced
this pull request
Nov 15, 2024
* Remove help commands from built-ins * Fix up docs and remove help_text_fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the help commands from the poise codebase, as part of #313.
These should be maintained outside of poise, as the code quality for them currently is shocking and causing issues with larger scale refactoring required. If anyone is using them, please reach out in the serenity discord to discuss if we should republish them under a
poise-helpcrate and you want to maintain that.