Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: fix handling of multiple timed events on a single track #96

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

FelixMcFelix
Copy link
Member

Fixes an issue where the EventData were not stored in reverse order, meaning that only the last added TimedEvent would be serviced.

This reverses the Ord for EventData, which should only be internally compared, allowing all timed events to be processed correctly in order.

Fixes #95.

Fixes an issue where the `EventData` were not stored in reverse order, meaning that only the last added TimedEvent would be serviced.

This reverses the `Ord` for `EventData`, which should only be internally compared, allowing all timed events to be processed correctly in order.

Fixes serenity-rs#95.
@FelixMcFelix FelixMcFelix merged commit e25cc14 into serenity-rs:current Sep 29, 2021
@FelixMcFelix FelixMcFelix deleted the fix-timed-events branch September 29, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed and delayed events when adding multiple track events
1 participant