-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model update september 24 #1474
Conversation
add Med42 v2 70B add Phi 3.5 mini instruct
add support for Med42 v2-70B add support for Phi 3.5-medium-instruct add support for Meditron v3-8B
WalkthroughThe changes involve updates to the Changes
Sequence Diagram(s)(No sequence diagrams generated as changes do not involve new features or modifications to control flow.) Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
README.md (2)
76-76
: LGTM: Comprehensive addition of Gemma models.The inclusion of Gemma models with various versions and configurations is a valuable addition to the supported models list. This expansion provides users with more options and keeps the documentation up-to-date with recent model releases.
Consider adding a brief description or link to the Gemma model's official documentation for users who might be unfamiliar with this model family.
83-83
: LGTM: Expanded model support for Med42, Meditron, and Meta-LlaMA-3.The changes effectively update and expand the supported models:
- Med42 now includes additional versions (v2-8B, v2-70B).
- Meditron has been updated with new versions (7B-Chat, 70B, 3-8B).
- Meta-LlaMA-3 is a new addition with multiple versions and configurations.
These updates significantly enhance the range of available models for users.
To improve clarity, consider adding a brief note or link explaining the differences between the various versions of each model family, especially for the newly added Meta-LlaMA-3.
Also applies to: 86-87
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
api/src/serge/data/models.json
is excluded by!**/*.json
Files selected for processing (1)
- README.md (2 hunks)
Additional comments not posted (3)
README.md (3)
55-55
: LGTM: Minor improvements to environment variables documentation.The changes to the environment variables table are minor but beneficial:
- The default value for
SERGE_JWT_SECRET
remains unchanged, maintaining consistency.- The description for
NODE_ENV
has been slightly reformatted, improving readability.These updates enhance the documentation without affecting functionality.
Also applies to: 57-57
88-88
: LGTM: Updated Mistral model versions.The Mistral model entry has been effectively updated with new versions:
- Addition of 7B-V0.1 and 7B-Instruct-v0.2 versions.
- Inclusion of 7B-OpenOrca, which is likely a fine-tuned version.
- Addition of Nemo-Instruct, expanding the range of instruction-tuned options.
These updates provide users with more choices and keep the documentation current with the latest Mistral releases.
95-95
: Update to OpenChat models requires clarification.The changes to the OpenChat model entry include:
- Addition of a new version: 8B-v3.6-20240522, which is a valuable update.
- A question mark has been added to the existing 7B-v3.5-1210 version.
Please clarify the reason for adding a question mark to the 7B-v3.5-1210 version. Is there uncertainty about its availability or compatibility? If there's an issue with this version, consider either removing it or adding a note explaining the concern.
To verify the current state of OpenChat models, you can run the following script:
This script will help gather more context about the OpenChat models in the repository and any related discussions.
Open pull requests when files are properly formatted |
No description provided.