-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: allow using system gtest copy #113
Conversation
Distributions often do builds with no network access available for both security reasons and also to ensure reproducibility. This change tells CMake to query the system for a copy of gtest, but if it's not available, it'll fall back to downloading via FetchContent.
Accepted. Thank you! |
Thanks! |
Unfortunately, the change does not go plain. Here is my build log: user@linux-on-jaguar: -- Configuring incomplete, errors occurred! CMake Error at /usr/share/cmake-3.22/Modules/FetchContent.cmake:1075 (message): -- Configuring incomplete, errors occurred! |
I have reverted the change for the meantime. Please resubmit after the fix |
Thanks, I'll give it another look, it definitely fetched for me. |
While testing, please don't forget to turn on the testing: ELFIO_BUILD_TESTS=ON |
Oh dear. It's because it needs CMake 3.24 minimum. |
The library switched to a newer 'googletest' archive with your change in |
Distributions often do builds with no network access available for both security reasons and also to ensure reproducibility.
This change tells CMake to query the system for a copy of gtest, but if it's not available, it'll fall back to downloading via FetchContent.