Skip to content

Commit

Permalink
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_…
Browse files Browse the repository at this point in the history
…log (grpc#36526)

[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log

In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.

We have the following mapping
1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)

Reviewers need to check :
1. If the above mapping is correct.
2. The content of the log is as before.

gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.

Closes grpc#36526

COPYBARA_INTEGRATE_REVIEW=grpc#36526 from tanvi-jagtap:test_large_interop_client_gpr_log 46a657f
PiperOrigin-RevId: 630993244
  • Loading branch information
tanvi-jagtap authored and copybara-github committed May 6, 2024
1 parent a20f020 commit 7cc547d
Show file tree
Hide file tree
Showing 2 changed files with 157 additions and 183 deletions.
1 change: 1 addition & 0 deletions test/cpp/interop/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ grpc_cc_library(
external_deps = [
"absl/flags:flag",
"absl/log:check",
"absl/log:log",
],
language = "C++",
deps = [
Expand Down
Loading

0 comments on commit 7cc547d

Please sign in to comment.