Improve Honeypot instructions in README #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2023 17:15
Include honeypotInputProps acquisition and introduciton to react context
dvnrsn
commented
Nov 16, 2023
| @@ -1903,7 +1903,7 @@ export default function Component() { | |||
| // more code here | |||
| return ( | |||
| // some JSX | |||
| <HoneypotProvider> | |||
| <HoneypotProvider {...honeypotInputProps}> | |||
There was a problem hiding this comment.
Took me way too long to realize I was missing this and crucially the honeypot works halfway without it! It'd be wise to help the developer be completely explicit about the context here.
sergiodxa
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal fixes a few grammar issues and expands docs to help developer get a working honeypot