Deduplicate connections to SSE with useEventSource regardless of the event #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use-event-source
has a feature to deduplicate SSE connections in order to lower the number ofEventStream
s a browser needs to hold. However, when event name is the only differences, it creates multiple identicalEventStream
s and then on client side it listens to different events.Instead, we can create a single
EventStream
for the same URL and withCredentials flag, no matter what event is.Example
Given code like these
It creates identical event streams
after