New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional `id` attribute to `ScriptDescriptor` #379

Merged

sergiodxa merged 1 commit into sergiodxa:main from speechmatics:main

Sep 20, 2024

Contributor

mnemitz commented Aug 16, 2024

This is to allow for later referencing of external scripts by ID if desired.

We're specifically using this functionality in our app to interact with a third party script's globals only after the script has loaded.

Happy to discuss if you have any questions about this, or if there's a better approach!


          Add optional id attribute to ScriptDescriptor

ed859e9

This is to allow for later referencing of external scripts by ID if
desired

sergiodxa approved these changes

View reviewed changes

sergiodxa self-assigned this

sergiodxa added the enhancement label

sergiodxa merged commit 6d17f05 into sergiodxa:main

kodiakhq bot referenced this pull request in technifit/tasker


          fix(deps): update dependency remix-utils to v7.7.0 (#1029)

71b5640

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [remix-utils](https://redirect.github.com/sergiodxa/remix-utils) | [`7.6.0` -> `7.7.0`](https://renovatebot.com/diffs/npm/remix-utils/7.6.0/7.7.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/remix-utils/7.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/remix-utils/7.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/remix-utils/7.6.0/7.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/remix-utils/7.6.0/7.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sergiodxa/remix-utils (remix-utils)</summary>

### [`v7.7.0`](https://redirect.github.com/sergiodxa/remix-utils/releases/tag/v7.7.0)

[Compare Source](https://redirect.github.com/sergiodxa/remix-utils/compare/v7.6.0...v7.7.0)



#### What's Changed

##### New Features

-   Make TypedCookie take input type of schema by [@&#8203;nichtsam](https://redirect.github.com/nichtsam) in [https://github.com/sergiodxa/remix-utils/pull/363](https://redirect.github.com/sergiodxa/remix-utils/pull/363)
-   Add enabled flag to useEventSource (default = true) by [@&#8203;rossipedia](https://redirect.github.com/rossipedia) in [https://github.com/sergiodxa/remix-utils/pull/387](https://redirect.github.com/sergiodxa/remix-utils/pull/387)
-   Add optional `id` attribute to `ScriptDescriptor` by [@&#8203;mnemitz](https://redirect.github.com/mnemitz) in [https://github.com/sergiodxa/remix-utils/pull/379](https://redirect.github.com/sergiodxa/remix-utils/pull/379)

##### Documentation Changes

-   Add warning about `preloadRouteAssets` by [@&#8203;jansedlon](https://redirect.github.com/jansedlon) in [https://github.com/sergiodxa/remix-utils/pull/349](https://redirect.github.com/sergiodxa/remix-utils/pull/349)
-   Setup typedoc to generate API reference docs by [@&#8203;sergiodxa](https://redirect.github.com/sergiodxa) in [https://github.com/sergiodxa/remix-utils/pull/356](https://redirect.github.com/sergiodxa/remix-utils/pull/356)
-   Fix typo in README by [@&#8203;nickretallack](https://redirect.github.com/nickretallack) in [https://github.com/sergiodxa/remix-utils/pull/377](https://redirect.github.com/sergiodxa/remix-utils/pull/377)

##### Other Changes

-   Bump eslint-plugin-testing-library from 6.2.0 to 6.2.1 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/sergiodxa/remix-utils/pull/337](https://redirect.github.com/sergiodxa/remix-utils/pull/337)
-   Bump [@&#8203;testing-library/react](https://redirect.github.com/testing-library/react) from 14.3.0 to 15.0.2 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/sergiodxa/remix-utils/pull/338](https://redirect.github.com/sergiodxa/remix-utils/pull/338)
-   Bump [@&#8203;vitest/coverage-v8](https://redirect.github.com/vitest/coverage-v8) from 1.4.0 to 1.5.0 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/sergiodxa/remix-utils/pull/339](https://redirect.github.com/sergiodxa/remix-utils/pull/339)
-   Bump [@&#8203;types/react](https://redirect.github.com/types/react) from 18.2.75 to 18.2.78 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/sergiodxa/remix-utils/pull/340](https://redirect.github.com/sergiodxa/remix-utils/pull/340)
-   Bump type-fest from 4.15.0 to 4.18.1 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/sergiodxa/remix-utils/pull/360](https://redirect.github.com/sergiodxa/remix-utils/pull/360)
-   Bump eslint-plugin-testing-library from 6.2.1 to 6.2.2 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/sergiodxa/remix-utils/pull/348](https://redirect.github.com/sergiodxa/remix-utils/pull/348)
-   Switch to Biome by [@&#8203;sergiodxa](https://redirect.github.com/sergiodxa) in [https://github.com/sergiodxa/remix-utils/pull/361](https://redirect.github.com/sergiodxa/remix-utils/pull/361)
-   Bump oven-sh/setup-bun from 1 to 2 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/sergiodxa/remix-utils/pull/368](https://redirect.github.com/sergiodxa/remix-utils/pull/368)

#### New Contributors

-   [@&#8203;jansedlon](https://redirect.github.com/jansedlon) made their first contribution in [https://github.com/sergiodxa/remix-utils/pull/349](https://redirect.github.com/sergiodxa/remix-utils/pull/349)
-   [@&#8203;nickretallack](https://redirect.github.com/nickretallack) made their first contribution in [https://github.com/sergiodxa/remix-utils/pull/377](https://redirect.github.com/sergiodxa/remix-utils/pull/377)
-   [@&#8203;mnemitz](https://redirect.github.com/mnemitz) made their first contribution in [https://github.com/sergiodxa/remix-utils/pull/379](https://redirect.github.com/sergiodxa/remix-utils/pull/379)

**Full Changelog**: sergiodxa/remix-utils@v7.6.0...v7.7.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/technifit/tasker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels