fix: while validating for offset, check for offset's value for NaN in…

…stead length (#2124)
serialport · Aug 11, 2020 · 4215122 · 4215122
1 parent 19fb5f8
commit 4215122
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/binding-abstract/lib/index.js b/packages/binding-abstract/lib/index.js
@@ -85,8 +85,8 @@ The in progress reads must error when the port is closed with an error object th
       throw new TypeError('"buffer" is not a Buffer')
     }
 
-    if (typeof offset !== 'number' || isNaN(length)) {
-      throw new TypeError(`"offset" is not an integer got "${isNaN(length) ? 'NaN' : typeof offset}"`)
+    if (typeof offset !== 'number' || isNaN(offset)) {
+      throw new TypeError(`"offset" is not an integer got "${isNaN(offset) ? 'NaN' : typeof offset}"`)
     }
 
     if (typeof length !== 'number' || isNaN(length)) {