fix(packages/bindings#write): do not call native binding for empty bu…

…ffers
serialport · Nov 5, 2018 · d347f3b · d347f3b
1 parent f70d672
commit d347f3b
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 21 deletions.
diff --git a/packages/bindings/lib/darwin.js b/packages/bindings/lib/darwin.js
@@ -59,13 +59,16 @@ class DarwinBinding extends AbstractBinding {
   }
 
   write(buffer) {
-    this.writeOperation = super
-      .write(buffer)
-      .then(() => unixWrite.call(this, buffer))
-      .then(() => {
-        this.writeOperation = null
-      })
-    return this.writeOperation
+    if (buffer.length > 0) {
+      this.writeOperation = super
+        .write(buffer)
+        .then(() => unixWrite.call(this, buffer))
+        .then(() => {
+          this.writeOperation = null
+        })
+      return this.writeOperation
+    }
+    return Promise.resolve()
   }
 
   update(options) {

diff --git a/packages/bindings/lib/linux.js b/packages/bindings/lib/linux.js
@@ -59,13 +59,16 @@ class LinuxBinding extends AbstractBinding {
   }
 
   write(buffer) {
-    this.writeOperation = super
-      .write(buffer)
-      .then(() => unixWrite.call(this, buffer))
-      .then(() => {
-        this.writeOperation = null
-      })
-    return this.writeOperation
+    if (buffer.length > 0) {
+      this.writeOperation = super
+        .write(buffer)
+        .then(() => unixWrite.call(this, buffer))
+        .then(() => {
+          this.writeOperation = null
+        })
+      return this.writeOperation
+    }
+    return Promise.resolve()
   }
 
   update(options) {

diff --git a/packages/bindings/lib/win32.js b/packages/bindings/lib/win32.js
@@ -66,13 +66,16 @@ class WindowsBinding extends AbstractBinding {
   }
 
   write(buffer) {
-    this.writeOperation = super
-      .write(buffer)
-      .then(() => promisify(binding.write)(this.fd, buffer))
-      .then(() => {
-        this.writeOperation = null
-      })
-    return this.writeOperation
+    if (buffer.length > 0) {
+      this.writeOperation = super
+        .write(buffer)
+        .then(() => promisify(binding.write)(this.fd, buffer))
+        .then(() => {
+          this.writeOperation = null
+        })
+      return this.writeOperation
+    }
+    return Promise.resolve()
   }
 
   update(options) {