-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable RTS on Windows #1277
Conversation
(We don't use grunt?) This looks good, will give it a test and then probably a merge! Thank you so much! |
Regarding Grunt from Contributing.MD
I can try to add the other options if I get a minute tonight. |
Thanks! And I'll fix that doc bug! Haven't used grunt in a while.
…On Fri, Aug 4, 2017, 5:48 PM Joshua Shireman ***@***.***> wrote:
Regarding Grunt from Contributing.MD
Submitting Pull Requests
To contribute code to SerialPort, fork the project onto your github
account and do your work in a branch. Before you submit the PR, make sure
to rebase master into your branch so that you have the most recent changes
and nothing breaks or conflicts. Lint and test your code using *grunt.*
Also squash your commits to a reasonable size before submitting.
I can try to add the other options if I get a minute tonight.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1277 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABlbrwOCv-4PCcVv2I3owqh-63Lx5CUks5sU5HDgaJpZM4Or6fL>
.
|
…omplete in terms of missing the XonChar, XoffChar, XonLim fields of DCB, but I am not as familiar with this aspect of serial comms.
I gave up on |
@kealist we can have binding specific options that we can pass when you want to use them. It sounds like it would make sense to put This PR is good! I have a question about releasing it. This looks like it will change the default behavior. In our open settings |
It is my understanding that USB-based traditional serial devices generally are less likely to use it, so I think disabled by default is probably better, but I'm not 100% sure. |
In terms of node modules updating, will I see this patch if I update the serialport node module (i.e. does it pull code straight from github), or would I have to wait for an official release? I tried to find the answer but don't see anything clearly. |
It's up to you. I'll have a beta release before the next official release where you can test this and a few other changes out. This change is major enough we'll have to do a 6x release. You can install the latest stable via |
Seems getting the build system up on this old netbook isn't working smoothly, so I'll have to wait for beta |
### Bug Fixes * **linux:** The productID should be a number not a description string ([#1279](#1279)) ([bf46f68](bf46f68)) * **tests:** fixup for [#1279](#1279) ([#1285](#1285)) ([56074f6](56074f6)) * **windows:** Add option to disable RTS ([#1277](#1277)) ([5b8d163](5b8d163)) * **windows:** Parse more types of pnpIds ([#1288](#1288)) ([0b554d7](0b554d7)), closes [#1220](#1220) ### Chores * **binaries:** Lets switch to prebuild! ([#1282](#1282)) ([8c36e99](8c36e99)) ### Features * **test:** tone down codecov comments ([#1289](#1289)) ([749ffac](749ffac)) ### BREAKING CHANGES * **binaries:** I'm considering the switch to `prebuild` a breaking change because it's substantially changes our install processes. It's also possible the install flags to ensure downloading or building from source has changed slightly. That's not our api per say, but it's enough. * **windows:** We previously hard coded to have RTS on for windows at all times it now default to off.
|
Regarding #1276 I was trying to add this option. I am not familiar with getting grunt working, but I'll go ahead and push this and test it once I figure out how. Thanks