-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile error #1470
Comments
Cc @Fumon |
Sorry for the delay, notification got filtered. Looks like an easy fix. Seems to be an issue with musl libc which Alpine Linux is based on. Found a reference and fix in a similar serial based project here which appeared to resolve the issue. I have a branch for you to try sticking in your package.json to see if it compiles https://github.com/Fumon/node-serialport/tree/fix_musl If I don't hear from you @piechade, I'll spin up an Alpine VM to test this myself. |
@Fumon i will test it later this day. I need to look how to use GitHub instant of npm. |
Ah, you need I just built a docker image using:
Which built successfully. |
Sorry about that, i forgot the branch. For me ist also everything working. |
Fixes #1470 After adding the new custom baud rate implementation for Linux, a build breaking bug occurred on Alpine Linux due to musl's handling of the kernel header files involved with ioctls. This patch introduces a fix by using the solution found [here](tio/tio#65) on a similar, serial oriented project. Tested in an Alpine Linux docker container. Passing all hardware tests.
…lport#1487) Fixes serialport#1470 After adding the new custom baud rate implementation for Linux, a build breaking bug occurred on Alpine Linux due to musl's handling of the kernel header files involved with ioctls. This patch introduces a fix by using the solution found [here](tio/tio#65) on a similar, serial oriented project. Tested in an Alpine Linux docker container. Passing all hardware tests.
…lport#1487) Fixes serialport#1470 After adding the new custom baud rate implementation for Linux, a build breaking bug occurred on Alpine Linux due to musl's handling of the kernel header files involved with ioctls. This patch introduces a fix by using the solution found [here](tio/tio#65) on a similar, serial oriented project. Tested in an Alpine Linux docker container. Passing all hardware tests.
Fixes #1470 After adding the new custom baud rate implementation for Linux, a build breaking bug occurred on Alpine Linux due to musl's handling of the kernel header files involved with ioctls. This patch introduces a fix by using the solution found [here](tio/tio#65) on a similar, serial oriented project. Tested in an Alpine Linux docker container. Passing all hardware tests.
Summary of Problem
CXX(target) Release/obj.target/serialport/src/serialport_linux.o
../src/serialport_linux.cpp: In function 'int linuxSetCustomBaudRate(int, unsigned int)':
../src/serialport_linux.cpp:10:18: error: 'TCGETS2' was not declared in this scope
if(ioctl(fd, TCGETS2, &t)) {
^~~~~~~
../src/serialport_linux.cpp:18:18: error: 'TCSETS2' was not declared in this scope
if(ioctl(fd, TCSETS2, &t)) {
^~~~~~~
../src/serialport_linux.cpp: In function 'int linuxGetSystemBaudRate(int, int*)':
../src/serialport_linux.cpp:29:16: error: 'TCGETS2' was not declared in this scope
if(ioctl(fd, TCGETS2, &t)) {
^~~~~~~
make: *** [serialport.target.mk:98: Release/obj.target/serialport/src/serialport_linux.o] Error 1
Steps and Code to Reproduce the Issue
npm install
The text was updated successfully, but these errors were encountered: