Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation for prebuilding gyp #1273

Closed
wants to merge 2 commits into from
Closed

Conversation

akaJes
Copy link
Contributor

@akaJes akaJes commented Aug 2, 2017

create at home folder token file .github.json

{ "OAuth":"xxxxxxxxxxxxxxKEYxxxxxxxxxxxxxx" }

and type npm run package for building and publishing for each OS
#1180

@codecov-io
Copy link

Codecov Report

Merging #1273 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
+ Coverage   78.87%   79.01%   +0.14%     
==========================================
  Files          19       18       -1     
  Lines         890      834      -56     
  Branches      163      159       -4     
==========================================
- Hits          702      659      -43     
+ Misses        188      175      -13
Impacted Files Coverage Δ
lib/bindings/auto-detect.js 69.23% <0%> (-30.77%) ⬇️
lib/bindings/win32.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c7dd4...71bf8fe. Read the comment docs.

@reconbot
Copy link
Member

reconbot commented Aug 4, 2017

Awesome! I took your files from your repo and I made https://github.com/EmergingTechnologyAdvisors/node-serialport/compare/prebuild I have no pr yet as I am not yet sure this is successful. Do I need to use your "pre-gyp-pack" settings or do default work?

@akaJes
Copy link
Contributor Author

akaJes commented Aug 4, 2017

I did it 2 months ago and it was a single way to reach my goal. And this pr i have created to show how it simple.
Yes you need to add options to your package.json, but i can make some modifications to the pre-gyp-pack package

@reconbot
Copy link
Member

reconbot commented Aug 6, 2017

@akaJes It looks like #1282 will do what we need with a smaller package size and automated builds. Does your pr accomplish anything that #1282 does not?

I'm glad we're going to get this in. Thank again for your help!

@reconbot reconbot closed this Aug 6, 2017
@lock lock bot locked and limited conversation to collaborators Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants