Adding option to include delimiter in the DelimiterParser transform. #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis takes a really long time for osx builds but since this isn't os specific I'm going to just merge. |
oteku
pushed a commit
to Cutii/node-serialport
that referenced
this pull request
Apr 9, 2018
reconbot
pushed a commit
that referenced
this pull request
Jul 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
includeDelimiterboolean option to theDelimiterParserthat includes the delimiter in its output.In the
4.xseries, I used theDelimiterParserrelying on this, because some of the protocols used in the devices I'm operating with responds with a single delimiter as anACK. The new transform does not trigger an event when an empty delimiter is sent. I added a new line to the first test to illustrate this, sending a single delimiter to the parser and assuring the Sinon spy is only called twice.I also added a new test with
includeDelimiter: true.Thanks for you work!