-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'cc' to lint the C++ code on 'npm lint' #1501
Conversation
Get it passing and will happily merge 👍 |
Apparently the build fails because some file is renamed into |
ZOMG, and some travis tests are running the c++ linter over the whole nodejs source code tree, failing everywhere 🤦♂️ |
OK, the linux/mac builds pass 🎉, but apparently I made some change that made the win32 builds fail 😢:
|
🎉 |
Can you rebase? |
4954615
to
40592eb
Compare
Make linter happier. Make linter happier.
Codecov Report
@@ Coverage Diff @@
## master #1501 +/- ##
=========================================
+ Coverage 79.04% 79.8% +0.76%
=========================================
Files 21 19 -2
Lines 940 822 -118
Branches 170 165 -5
=========================================
- Hits 743 656 -87
+ Misses 197 166 -31
Continue to review full report at Codecov.
|
This is great, thank you! |
The whitespace fumble at https://github.com/node-serialport/node-serialport/pull/1483/files#r168511525 made me think that
node-serialport
useseslint
for linting the javascript code, but doesn't do anything for the c++ code.This change adds
cc
as a dependency, which in turn runs the pythoncpplint
script. All of the c++ code, except for some bits in the osx headers, seem to pass the linting.