Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't restart polling when libuv emits an error #1804

Closed
wants to merge 1 commit into from
Closed

Fix: Don't restart polling when libuv emits an error #1804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/bindings/src/poller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ void Poller::onData(uv_poll_t* handle, int status, int events) {
// fprintf(stdout, "OnData status=%d events=%d\n", status, events);
argv[0] = Nan::Null();
argv[1] = Nan::New<v8::Integer>(events);
// remove triggered events from the poll
int newEvents = obj->events & ~events;
obj->poll(newEvents);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok yes this wont update the poll events on an error - but no this wont stop the poller on an error we should try to call uv_poll_stop(poll_handle);

}
// remove triggered events from the poll
int newEvents = obj->events & ~events;
obj->poll(newEvents);

obj->callback.Call(2, argv, obj);
}
Expand Down