fix: bindings.close() should cause a canceled read error #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconbot
force-pushed
the
reconbot/canceled
branch
2 times, most recently
from
13cfd9a
to
52b8e9f
Compare
`stream` seems unaffected by this but other interfaces may not be so forgiving. - removed the unused disconnect handler that we passed to bindings in tests. - moved shouldReject to a test global - unit tested unixRead
reconbot
force-pushed
the
reconbot/canceled
branch
from
52b8e9f
to
a5f1d04
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamseems unaffected by this but other interfaces may not be so forgiving.