Make sure necessary cleanups such as uv_mutex_unlock are called always in GetSerialDevices(). #2343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function GetSerialDevices() (in darwin_list.cpp), there are code paths that rest of iteration is skipped by
continue
statements. But by taking such paths, some necessary cleanups are also skipped (e.g., uv_mutex_unlock). And missing uv_mutex_unlock(), for example, results dead locks on next iteration.This change makes sure that
IOObjectRelease(device)
is always called ifdevice
was not NULL,uv_mutex_unlock(&list_mutex)
is always called ifuv_mutex_lock(&list_mutex)
was called, andIOObjectRelease(modemService)
is always called ifmodemService
was not NULL.