Adding node-gyp as a dependency #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This shouldn't be necessary but we've had numerous people run into the problem so I'll merge your change in. |
joeferner
added a commit
that referenced
this pull request
Jul 29, 2012
Adding node-gyp as a dependency
reconbot
pushed a commit
that referenced
this pull request
Jul 24, 2018
Adding node-gyp as a dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing node-serialport without node-gyp globally installed, the actual build does not happen and so the "build" folder doesn't get created. This doesn't trigger an error, but does result in node-serialport not actually working as expected. Adding the node-gyp dependency solves this issue.