Renamed the parameter to keep it consistent with the rest of the code base. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pawelpabich! Given this is a breaking change it'd probably necessitate a major version bump (though with everything AI still in beta that may not be so much the case...) Thoughts @jbattermann ? |
|
Thanks @pawelpabich ! As AI itself is still in beta/preview (afaik it'll go stable shortly though) I think it's fine to rename the parameter at this stage. Once AI hits 1.0 the AI sink should probably also prevent breaking changes in the stable branch.. |
|
Thanks guys! I spent some time Googling for "componentId" hence the pull request :). |
joergbattermann
added a commit
that referenced
this pull request
Jun 4, 2015
Renamed the parameter to keep it consistent with the rest of the code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.