.NET Core App 3.0 target; misc clean-up #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
commented
Feb 4, 2020
| @@ -18,21 +18,15 @@ | |||
| <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute> | |||
| <RootNamespace>Serilog</RootNamespace> | |||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
| <DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences> | |||
| <DisableImplicitFrameworkReferences Condition=" '$(TargetFramework)' == 'netstandard1.3' ">true</DisableImplicitFrameworkReferences> | |||
There was a problem hiding this comment.
Had to make this change to get the .NET 4.5 target building with the current tools 🤔
There was a problem hiding this comment.
you should be able to safely remove DisableImplicitFrameworkReferences altogether along with the System* package references since the targeted frameworks already have implicit references to all those packages (>= 4.3.0)
There was a problem hiding this comment.
Thanks for the note. This was added originally to prevent an explosion of dependencies on .NET Framework when installing packages that targeted .NET Standard 1.x - the exact issues elude me know, and I'd love to be able to remove it, but probably best in a separate/more carefully-considered PR. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104