Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin the assembly version #227

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Unpin the assembly version #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1ba60e
Unpin the assembly version; fixes #135
nblumhardt Jun 22, 2021
6f43751
Remove matching test
nblumhardt Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Serilog.Sinks.File/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
using System.Reflection;
using System.Runtime.CompilerServices;

[assembly: AssemblyVersion("2.0.0.0")]

[assembly: CLSCompliant(true)]

[assembly: InternalsVisibleTo("Serilog.Sinks.File.Tests, PublicKey=" +
Expand Down
1 change: 0 additions & 1 deletion src/Serilog.Sinks.File/Serilog.Sinks.File.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<RepositoryUrl>https://github.com/serilog/serilog-sinks-file</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
<RootNamespace>Serilog</RootNamespace>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<DisableImplicitFrameworkReferences Condition=" '$(TargetFramework)' == 'netstandard1.3' ">true</DisableImplicitFrameworkReferences>
Expand Down
10 changes: 1 addition & 9 deletions test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System.IO;
using System.IO.Compression;
using System.Linq;
using System.Reflection;
using Xunit;
using Serilog.Events;
using Serilog.Sinks.File.Tests.Support;
Expand Down Expand Up @@ -128,7 +127,7 @@ public void WhenRetentionCountAndTimeIsSetOldFilesAreDeletedByCount()
Assert.True(System.IO.File.Exists(files[2]));
});
}

[Fact]
public void WhenRetentionCountAndArchivingHookIsSetOldFilesAreCopiedAndOriginalDeleted()
{
Expand Down Expand Up @@ -261,13 +260,6 @@ public void IfTheLogFolderDoesNotExistItWillBeCreated()
}
}

[Fact]
public void AssemblyVersionIsFixedAt200()
{
var assembly = typeof(FileLoggerConfigurationExtensions).GetTypeInfo().Assembly;
Assert.Equal("2.0.0.0", assembly.GetName().Version.ToString(4));
}

static void TestRollingEventSequence(params LogEvent[] events)
{
TestRollingEventSequence(
Expand Down