-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option for livestream #89
Conversation
@@ -92,9 +106,9 @@ function ready(cb){ | |||
cb(); | |||
} | |||
|
|||
function initCanvas() { | |||
function initCanvas(_config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing in the _config
parameter, you could also use the global one (see L51)
Thanks for providing this PR. Works for me. Maybe you could drop one or two lines into the README to tell people how to use it (somewhere around https://github.com/serratus/quaggaJS#quaggainitconfig-callback). |
Option for specifying an entry point for the video-element.
Thanks for everything. Your changes will be made available in the next release which is scheduled in the next few days. |
As discussed in #52 it is now possible to use any arbitrary element or selector, like so:
or