Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue wit custom authorizers when using pseudo parameters plugin #113

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

aleksdikanski
Copy link

Fixes #112

@aleksdikanski
Copy link
Author

I have created a example project that shows the issue: //github.com/aleksdikanski/serverless-example-project.git

Tag 'before' uses the current alias plugin version 1.6.1 and tag 'pseudo-parameter-fix' uses the implementation from my PR

@HyperBrain
Copy link
Member

@aleksdikanski Good catch. I will do a 1.6.2 release soon.

@HyperBrain HyperBrain added this to the 1.6.2 milestone Mar 20, 2018
Copy link
Member

@HyperBrain HyperBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HyperBrain HyperBrain merged commit b65e258 into serverless-heaven:master Mar 20, 2018
@HyperBrain HyperBrain modified the milestones: 1.6.2, 1.7.0 Mar 22, 2018
defnotrobbie pushed a commit to 1stdibs/serverless-aws-alias that referenced this pull request Nov 14, 2022
Fix issue wit custom authorizers when using pseudo parameters plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants