Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic rewrites 404ing #733

Closed
patricktyndall opened this issue Nov 1, 2020 · 1 comment · Fixed by #759
Closed

Dynamic rewrites 404ing #733

patricktyndall opened this issue Nov 1, 2020 · 1 comment · Fixed by #759
Assignees
Labels
bug Something isn't working release-1.19

Comments

@patricktyndall
Copy link

@dphang this is a continuation of the use case / repro from #705. I'm actually surprised to be just finding this now. In all of the discussion this specific setup must have been missed, but it's really the central issue for my use case.

Describe the bug

With a page defined at pages/content/[...all ] and the following rewrite, visiting /dynamic-1 gives a 404.

{
	source: '/:path*',
	destination: '/:path*',
},{
	source: '/:path*',
	destination: '/content/:path*',
}

Actual behavior

I get a 404 visiting /dynamic-1, where next server gives a 200.

Expected behavior

200

Steps to reproduce

Versions

  • OS/Environment: Mac
  • @sls-next/serverless-component version: 1.18.0-alpha.27
  • Next.js version: 9.5.5
@dphang
Copy link
Collaborator

dphang commented Nov 2, 2020

Yes, I think it should be because of the no-op rewrite not being implemented, I had thought you did not need it anymore based on your latest comments, so I didn't prioritize it. I'll work on it this upcoming week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-1.19
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants