Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-at-edge): no-op rewrite support #759

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Nov 3, 2020

Should fix: #733

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #759 into master will increase coverage by 0.03%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   79.66%   79.70%   +0.03%     
==========================================
  Files          55       55              
  Lines        1800     1808       +8     
  Branches      391      394       +3     
==========================================
+ Hits         1434     1441       +7     
- Misses        308      309       +1     
  Partials       58       58              
Impacted Files Coverage Δ
...ackages/libs/lambda-at-edge/src/default-handler.ts 92.72% <66.66%> (-0.33%) ⬇️
packages/libs/lambda-at-edge/src/api-handler.ts 86.66% <100.00%> (+0.30%) ⬆️
...ckages/libs/lambda-at-edge/src/routing/rewriter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff1d46...a04630b. Read the comment docs.

@dphang dphang merged commit 2107ab1 into master Nov 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/no-op-rewrite branch November 3, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic rewrites 404ing
1 participant