Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand support for Redshift Data #576

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

kmfukuda
Copy link
Contributor

@kmfukuda kmfukuda commented Aug 1, 2023

Expands support for Redshift Data.

It adds support for running statements on Redshift Serverless workgroups as well as using Secrets Manager secrets or IAM identities for authentication.

@kmfukuda
Copy link
Contributor Author

kmfukuda commented Sep 2, 2023

Hi @lopburny Is there any chance that this could be included in the next release?

@horike37
Copy link
Collaborator

@kmfukuda
Thank you for this PR. Looks good to me.

Have you done actual tests for this feature? I mean like if this feature doesn't introduce any side effects to existing features, or if this keeps backward compatibility. Because I couldn't have enough time to check it right now.

If so, I will merge this PR and release it

@kmfukuda
Copy link
Contributor Author

kmfukuda commented Oct 1, 2023

I deployed and executed some state machines for testing using the code before and after the change, and they all behaved as intended.

To be specific, I deployed and executed a state machine for each of the only actions redshift-data:ExecuteStatement and redshift-data:BatchExecuteStatement that can result in different permissions because of the change and each of parameter sets that collectively enable covering lines 251-315, and the state machines showed that the code after the change supports all the cases that the code before the change supports.

I have also confirmed that the other actions that are handled by getRedshiftDataPermissions within lines 317-320 support the newly supported cases.

@horike37
Copy link
Collaborator

horike37 commented Oct 1, 2023

Thank you for the explanation. Perfect!

@horike37 horike37 merged commit bd9363b into serverless-operations:master Oct 1, 2023
1 check passed
@horike37
Copy link
Collaborator

horike37 commented Oct 1, 2023

🎉 This PR is included in version 3.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants