Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force noEmit compiler option to be false #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StephanBijzitter
Copy link

When a developer makes a mistake and has noEmit with a value of true in their tsconfig.json, this plugin errors out with "Typescript compilation failed" message.
The message is wrong, as compilation actually did succeed. The real problem is that there simply were no files written to disk and as such there are no files for serverless to deploy.

To prevent developers from making this mistake, its value can be forced by the plugin.

When a developer makes a mistake and has noEmit with a value of true in their tsconfig.json, this plugin errors out with "Typescript compilation failed" message.
The message is wrong, as compilation actually did succeed. The real problem is that there  simply were no files written to disk and as such there are no files for serverless to deploy.

To prevent developers from making this mistake, its value can be forced by the plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant