Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #280: support docker lambdas #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShakedZrihen
Copy link

@ShakedZrihen ShakedZrihen commented Jun 6, 2023

workerB

Fixes #280

in order to support container Image for AWS Lambda, the handler attribute in function is no longer a mandatory one and can be replaced with image attribute.

  • Tested locally
  • Add tests

@ShakedZrihen ShakedZrihen changed the title fix: support docker lambdas Fix #280: support docker lambdas Jun 6, 2023
@ShakedZrihen ShakedZrihen marked this pull request as draft June 6, 2023 16:07
@ShakedZrihen ShakedZrihen marked this pull request as ready for review June 7, 2023 05:16
@lb-ronyeh
Copy link

Fixes #280

@nathanbbarton
Copy link

This would be an amazing addition, without it I have to explore other plugin options.

@darvesh
Copy link

darvesh commented Jul 27, 2023

I'd appreciate if this can get merged. I'm on stuck on this issue.

@pscanlon1
Copy link

can we get this merged? What is the holdup?

@douglasgsouza
Copy link

Fixes #227

Copy link

@douglasgsouza douglasgsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianluca-riskoptics
Copy link

What are we waiting on to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'split')
9 participants