Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure cast toString before trim on buffer #656

Merged
merged 1 commit into from
Dec 3, 2021
Merged

fix: Ensure cast toString before trim on buffer #656

merged 1 commit into from
Dec 3, 2021

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Dec 2, 2021

Ensure proper cast to string before trim call as reported in: #648 (comment)

@pgrzesik pgrzesik added the bug label Dec 2, 2021
@pgrzesik pgrzesik self-assigned this Dec 2, 2021
@obataku
Copy link

obataku commented Dec 3, 2021

thanks for addressing this so quickly

@pgrzesik pgrzesik requested a review from medikoo December 3, 2021 07:36
@pgrzesik
Copy link
Contributor Author

pgrzesik commented Dec 3, 2021

Sure thing, sorry for missing it on the first PR @obataku

@pgrzesik pgrzesik mentioned this pull request Dec 3, 2021
Closed
@f00f
Copy link

f00f commented Dec 3, 2021

👍

That bug bit me, too.

medikoo
medikoo approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pgrzesik pgrzesik merged commit f60eed1 into master Dec 3, 2021
@pgrzesik pgrzesik deleted the fix-trim-on-buffer branch December 3, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees

@pgrzesik pgrzesik

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgrzesik @obataku @f00f @medikoo