Add single value enum when using const keyword for compatiblity #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use extra single value enum where const is used due to lack of support from jsonschema2pojo
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
jsonschema2pojo does not support
const
keyword yet.This was causing a bug when using resusable tasks that have no value on
with
block. It would always match toCallAsyncAPI
.In order to achieve proper behaviour I added a single value
enum
below eachconst
. This will make it compatible with jsonschema2pojo while they solve the issue #1001.joelittlejohn/jsonschema2pojo#1001.
Also addded a test to validate the behaviour
Special notes for reviewers:
I think this may be a good idead to adopt as a single enum on the main spec too. const and single value enum are the same thing under the hood, for jsonschema2pojo at least.
Additional information (if needed):