Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collections.Mapping Errors Fix #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fauzaanu
Copy link

@fauzaanu fauzaanu commented Nov 5, 2022

change to collections.abc.Mapping from collections.Mapping as collections.Mapping is deprecated as of now

change to collections.abc.Mapping from collections.Mapping
@lnauta
Copy link

lnauta commented Jul 9, 2023

Did this patch myself and thought to merge it into the repo, and found this request is already there!

@sid3windr
Copy link

Also just patched this, wanted to bring a PR ;-)

@element-code
Copy link

Simply switch to python-a2, as this package is UNMAINTAINED

@sid3windr
Copy link

If only that had all the functionality of this library, right?

@Yepoleb
Copy link
Member

Yepoleb commented Sep 29, 2024

What's missing?

@sid3windr
Copy link

Master server query, as far as I can see. Which was likely not intended to be there, as it's a library implementing the server query protocol...

@Yepoleb
Copy link
Member

Yepoleb commented Sep 29, 2024

Oh right, I tried implementing that, but the Steam master server just spits out garbage after a certain point. The only reliable way to query servers is to use a proper steam client library like https://github.com/ValvePython/steam (yes, that's a different package).

@sid3windr
Copy link

Thanks for the pointer - for now, for me, python-valve works fine :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants