Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset char size even if bitmap buffer is null #243

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

indefini
Copy link
Contributor

I was getting incorrect bounds for glyphs after rasterizing the space(' ') glyph.

In rasterize_glyph(), there is an early return if the bitmap buffer is null (as it is a space) and because of that the char size is not reset correctly.
Then if you call raster_bounds for another glyph it loads it with the rasterize char size.

So I just removed the early return and add an else block, so the reset is called at the end.

I was getting incorrect bounds for glyphs after rasterizing the
space(' ') glyph.
In rasterize_glyph(), there is an early return if the bitmap buffer is
null (as it is a space) and because of that the char size is not reset
correctly. Then if you call raster_bounds for another glyph it loads it
with the rasterize char size.
@mrobinson mrobinson added this pull request to the merge queue May 18, 2024
Merged via the queue into servo:main with commit 7ebe4ea May 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants