Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore warnings in html5ever/src/tree_builder #551

Merged
merged 16 commits into from
Aug 31, 2024
Merged

Don't ignore warnings in html5ever/src/tree_builder #551

merged 16 commits into from
Aug 31, 2024

Commits on Aug 29, 2024

  1. remove unnecessary references 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    476ac06 View commit details
    Browse the repository at this point in the history

  2. remove unused imports 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    41ef380 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Restrict visibility of unreachable public items 

    This addresses the clippy::unreachable_pub lint
Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2efd47b View commit details
    Browse the repository at this point in the history

  2. Replace .filter(..).next() calls with .find(..) 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    99c7174 View commit details
    Browse the repository at this point in the history

  3. Remove unneeded "mut" qualifiers 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a2023cf View commit details
    Browse the repository at this point in the history

  4. Don't call .map with functions returning () 

    This fixes a clippy lint

Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    40f142e View commit details
    Browse the repository at this point in the history

  5. Replace trivial matches 

    These can all either use if-let branches
or the matches! macro

Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c9dfc6e View commit details
    Browse the repository at this point in the history

  6. ignore clippy warnings in autogenerated code 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4af55aa View commit details
    Browse the repository at this point in the history

  7. Elide lifetimes where possible 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d4e315a View commit details
    Browse the repository at this point in the history

  8. Remove empty string literals in println! 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9b2ab37 View commit details
    Browse the repository at this point in the history

  9. Use Option::as_ref/as_deref where possible 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b6ceb77 View commit details
    Browse the repository at this point in the history

  10. Remove unneeded () returns 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c4ed159 View commit details
    Browse the repository at this point in the history

  11. Remove unneeded field names 

    Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6fd42f8 View commit details
    Browse the repository at this point in the history

  12. Simplify pop_until_current a bit 

    This also fixes a clippy warning

Signed-off-by: Simon Wülker <[email protected]>
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f738e55 View commit details
    Browse the repository at this point in the history

  13. Ignore some variants that are never constructed 

    This is necessary to allow html5ever to build (due
to #[deny(warnings)].

We might want to remove these in the future,
but I'm not sure whether they're necessary.
    @simonwuelker
    simonwuelker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    86dcdeb View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Format html5ever/src/tree_builder/mod.rs 

    Signed-off-by: Martin Robinson <[email protected]>
    @mrobinson
    mrobinson committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    fce5183 View commit details
    Browse the repository at this point in the history