Add _LIBCPP_INLINE_VISIBILITY environment variable #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needed to fix servo/servo#22069 |
|
@bors-servo r+ |
|
📌 Commit 861f974 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 3, 2019
…r=jdm Add _LIBCPP_INLINE_VISIBILITY environment variable This patch allows the `_LIBCPP_INLINE_VISIBILITY` variable to be set by an environment variable, rather than just basing it on the compiler and target OS. It's needed for builds for Android targets which use the usual `libc++`, such as magicleap. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/180) <!-- Reviewable:end -->
4 tasks
|
💔 Test failed - checks-travis |
|
@bors-servo: retry
|
bors-servo
pushed a commit
that referenced
this pull request
May 3, 2019
…r=jdm Add _LIBCPP_INLINE_VISIBILITY environment variable This patch allows the `_LIBCPP_INLINE_VISIBILITY` variable to be set by an environment variable, rather than just basing it on the compiler and target OS. It's needed for builds for Android targets which use the usual `libc++`, such as magicleap. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/180) <!-- Reviewable:end -->
|
💔 Test failed - checks-travis |
|
I have retried the individual jobs that failed. |
|
@bors-servo r=jdm |
|
📌 Commit f97767d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 3, 2019
…r=jdm Add _LIBCPP_INLINE_VISIBILITY environment variable This patch allows the `_LIBCPP_INLINE_VISIBILITY` variable to be set by an environment variable, rather than just basing it on the compiler and target OS. It's needed for builds for Android targets which use the usual `libc++`, such as magicleap. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/180) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the
_LIBCPP_INLINE_VISIBILITYvariable to be set by an environment variable, rather than just basing it on the compiler and target OS. It's needed for builds for Android targets which use the usuallibc++, such as magicleap.This change is