Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 #175

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Version 1.0.0 #175

merged 1 commit into from
Nov 2, 2019

Conversation

mbrubeck
Copy link
Collaborator

@mbrubeck mbrubeck commented Oct 30, 2019

* [breaking change] Use `MaybeUninit` internally to avoid possible undefined behavior (servo#162, servo#170).
* [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (servo#145).
* [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (servo#164).
* [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8, _]>` can implement the `std::io::Write` trait (servo#173).
* Add support for 96-element small vectors, `SmallVec<[T; 96]>` (servo#163).
* Iterators now implement `FusedIterator` (servo#172).
* Indexing now uses the standard `SliceIndex` trait (servo#166).
* Remove the deprecated `VecLike` trait (servo#165).
* Use `NonNull` internally (servo#171).
* Add automatic fuzz testing and MIRI testing (servo#168, servo#162).
* Update syntax and formatting to Rust 2018 standard (servo#174, servo#167).
@mbrubeck mbrubeck mentioned this pull request Oct 30, 2019
12 tasks
@jdm
Copy link
Member

jdm commented Oct 30, 2019

@emilio Any feedback on this?

@emilio
Copy link
Member

emilio commented Oct 31, 2019

I'm ok with this. Not sure if we should wait more to get to 1.0, I don't have strong opinions on that :)

@jdm
Copy link
Member

jdm commented Oct 31, 2019

I found @mbrubeck's reasoning in #73 (comment) compelling.

@jdm
Copy link
Member

jdm commented Nov 2, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 523a6dc has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 523a6dc with merge 34c2628...

bors-servo pushed a commit that referenced this pull request Nov 2, 2019
Version 1.0.0

* Requires Rust 1.36 or later.
* [breaking change] Use `MaybeUninit` to avoid possible undefined behavior (#162, #170).
* [breaking change] The `drain` method now takes a range argument, just like the standard `Vec::drain` (#145).
* [breaking change] Remove the `unreachable` function and replace it with the new standard `unreachable_unchecked` function (#164).
* [breaking change] Use `no_std` by default. This crate depends only on `core` and `alloc` by default. If the optional `write` feature is enabled then it depends on `std` so that `SmallVec<[u8;_]>` can implement the `std::io::Write` trait (#173).
* Add support for 96-element small vectors, `SmallVec<[T; 96]>` (#163).
* Iterators now implement `FusedIterator` (#172).
* Indexing now uses the standard `SliceIndex` trait (#166).
* Remove the deprecated `VecLike` trait (#165).
* Use `NonNull` internally (#171).
* Add automatic fuzz testing and MIRI testing (#168, #162).
* Update syntax and formatting to Rust 2018 standard (#174, #167).
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 34c2628 to master...

@bors-servo bors-servo merged commit 523a6dc into servo:master Nov 2, 2019
bors bot added a commit to Amanieu/parking_lot that referenced this pull request Nov 4, 2019
188: Bump smallvec version to 1.0 r=Amanieu a=messense

See servo/rust-smallvec#175 for changelog

Co-authored-by: messense <[email protected]>
Centril added a commit to Centril/rust that referenced this pull request Nov 6, 2019
bump smallvec to 1.0

This includes servo/rust-smallvec#162, fixing an unsoundness in smallvec.

See servo/rust-smallvec#175 for the 1.0 release announcement.

Cc @mbrubeck @emilio
aardappel pushed a commit to google/flatbuffers that referenced this pull request Nov 11, 2019
LuckyRu pushed a commit to LuckyRu/flatbuffers that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants