Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE if a frame's file path is nil #14

Merged
merged 1 commit into from
Sep 6, 2016

Conversation

mikeclarke
Copy link
Contributor

I've encountered a situation where :class-path-url is unset for one of the frames in my stack trace, which causes a NullPointerException when file->source is called with nil for the file-path argument. io/resource handles some cases gracefully where the argument is an empty string or a file that doesn't exist (returning nil) but it blows up if passed nil directly. This patch is a small tweak that bails early if the input itself is nil.

@martinklepsch martinklepsch merged commit c86abb8 into sethtrain:master Sep 6, 2016
@martinklepsch
Copy link
Collaborator

released with 1.4.3. Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants