Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use metadeps to specify pkg-config dependencies declaratively #540

Merged
merged 1 commit into from
Dec 25, 2016

Conversation

joshtriplett
Copy link
Contributor

This makes it easier for distribution packaging tools to generate
appropriate package dependencies.

This makes it easier for distribution packaging tools to generate
appropriate package dependencies.
@sfackler
Copy link
Owner

Neat! It looks like this will bump the minimum supported Rust version to 1.13 due to the error-chain dependency.

@joshtriplett
Copy link
Contributor Author

joshtriplett commented Dec 24, 2016

@sfackler Interesting; I didn't realize that error-chain required 1.13. I reported that as rust-lang-deprecated/error-chain#101 .

If that issue gets addressed, hopefully everything else will work with Rust 1.10. If it doesn't, I may abandon error-chain in metadeps. (I like it, but I already think I may disable the backtrace feature that pulls in many dependencies. If it also prevents widespread use by projects that need to run on older Rust, then I'll have to drop it.)

@joshtriplett
Copy link
Contributor Author

@sfackler OK, I've gotten a change into error-chain so it works with Rust 1.10, and updated metadeps to work with that. As soon as error-chain 0.7.2 gets released to crates.io, I'll re-push this so it re-runs CI and confirms the functional build on Rust 1.10.

@sfackler
Copy link
Owner

Looks like that was published and the builds are happy. Thanks!

@sfackler sfackler merged commit 283036c into sfackler:master Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants