Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WorldClockView #229

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Add WorldClockView #229

wants to merge 9 commits into from

Conversation

ryonakano
Copy link
Collaborator

@hrstwn
Copy link

hrstwn commented May 1, 2023

Thank you!
Are you open to some design suggestions?

@ryonakano
Copy link
Collaborator Author

@hrstwn Yes, I would appreciate it if you, who has requested this feature, would give me suggestions or inputs about desigins, features, etc. 🎉

@hrstwn
Copy link

hrstwn commented May 1, 2023

Thank you 🙌
Some needed basic info:

  • Hours difference to our local timezone (1 hour ahead/behind, etc.)
  • See if the city's date is still yesterday or tomorrow, compared to our timezone
  • Some indicator to show if it's night or daytime there (an icon and color indicator would be nice)
  • country code, maybe (?) Sometimes I forget in what country the city located

@hrstwn
Copy link

hrstwn commented May 1, 2023

by the way, I made a mockup
HourglassWorldClock_mockup

@ryonakano
Copy link
Collaborator Author

Wow, thank you for your nice mockup and suggestions! It is helpful.
Specifically I really like the idea of night/daytime indicator! There are two icons weather-clear-night and weather-clear available in elementary OS so it shouldn't difficult to implement this desigin.

@ryonakano
Copy link
Collaborator Author

ryonakano commented May 1, 2023

Implemented these things:

  • Hours difference to our local timezone (1 hour ahead/behind, etc.)
  • See if the city's date is still yesterday or tomorrow, compared to our timezone
  • Some indicator to show if it's night or daytime there (an icon and color indicator would be nice)

and now it looks like this:

スクリーンショット 2023-05-01 16 05 55

TODO:

  • The location of city (it's hardcoded in the above screenshot. It would be nice if there are library to get it)
  • Provide a way to add new world clock
  • Provide a way to remove new world clock
  • Automatically update the time, delta, and indicator per minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants