Make database dumps work with the partitioned version_downloads table. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the database dumps does not work for the partioned version_downloads table. This change excludes the version_downloads table and all its partitions from the dumps.
smarnach
force-pushed
the
sg-partition-version-downloads
branch
from
71cde0c
to
8a5cca9
Compare
smarnach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the database dumps for the partitioned version_downloads table introduced in rust-lang#2203.
I introduced a
private_tablessetting in the database dump configuration that accepts glob patterns. The list includes the patternversion_downloads_*, so all programmatically created partitions should be automatically treated as private, and only the main tableversion_downloadsitself is included in the dump.