Skip to content

Commit

Permalink
elastic: fix filtering of float (#92583)
Browse files Browse the repository at this point in the history
Commit: 4fd6adebe2ac2e1c2d382315c253bc3c43a3d84d
  • Loading branch information
Hendrik Muhs authored and sourcegraph-bot committed Dec 28, 2022
1 parent e1a42c0 commit 6a61080
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ public void testKeywordsArray() throws IOException {
}, new AggTestConfig(builder, keywordType).withQuery(query));
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/92578")
public void testMixedSingleValues() throws IOException {
List<MultiValuesSourceFieldConfig> fields = new ArrayList<>();

Expand Down Expand Up @@ -326,9 +325,9 @@ public void testMixedSingleValues() throws IOException {
0.2
),
new FrequentItemSet(Map.of(IP_FIELD, List.of("192.168.0.1"), FLOAT_FIELD, List.of(4.1f), INT_FIELD, List.of(2)), 2, 0.2),
new FrequentItemSet(Map.of(FLOAT_FIELD, List.of(5), KEYWORD_FIELD1, List.of("host-2")), 2, 0.2),
new FrequentItemSet(Map.of(FLOAT_FIELD, List.of(5.0f), KEYWORD_FIELD1, List.of("host-2")), 2, 0.2),
new FrequentItemSet(Map.of(INT_FIELD, List.of(5), KEYWORD_FIELD1, List.of("host-2")), 2, 0.2),
new FrequentItemSet(Map.of(FLOAT_FIELD, List.of(5), KEYWORD_FIELD2, List.of("client-2")), 2, 0.2),
new FrequentItemSet(Map.of(FLOAT_FIELD, List.of(5.0f), KEYWORD_FIELD2, List.of("client-2")), 2, 0.2),
new FrequentItemSet(Map.of(IP_FIELD, List.of("192.168.0.5"), KEYWORD_FIELD2, List.of("client-2")), 2, 0.2)
);

Expand Down Expand Up @@ -792,7 +791,12 @@ private void assertResults(
+ " minimum_set_size: "
+ minimumSetSize
+ " size: "
+ size;
+ size
+ " string exclude: ["
+ stringExclude
+ "] int exclude: ["
+ intExclude
+ "]";

assertEquals(
"number of results do not match, " + setsAssertMessage,
Expand Down

0 comments on commit 6a61080

Please sign in to comment.