Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basic Slider component #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Basic Slider component #105

wants to merge 1 commit into from

Conversation

anitnilay20
Copy link
Contributor

  • Add slider mix max props

PR Details

Description

Please review the releases section of the repository to get the detailed information on changes.

Related Issue

  • This project only accepts pull requests related to open issues.
  • If suggesting a new feature or change, please discuss it in an issue first.
  • If fixing a bug, there should be an issue describing it with steps to reproduce.
  • Please link to the issue here: Create Issue

Motivation and Context

  • Why is this change required?
  • What problem does it solve?

How Has This Been Tested

  • Please describe in detail how you tested your changes.
  • Include details of your testing environment, and the tests you ran to.
  • see how your change affects other areas of the code, etc.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Go over all the following points, and put an x in all the boxes that apply.
  • If you're unsure about any of these, don't hesitate to ask. We're here to help!
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Asutosh989
Asutosh989 previously approved these changes Dec 5, 2021
Copy link
Contributor

@Asutosh989 Asutosh989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Add slider mix max props
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #105 (660fa1b) into master (3995ebd) will decrease coverage by 1.63%.
The diff coverage is 26.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   90.39%   88.75%   -1.64%     
==========================================
  Files         139      139              
  Lines        2196     2241      +45     
  Branches      524      535      +11     
==========================================
+ Hits         1985     1989       +4     
- Misses        211      252      +41     
Impacted Files Coverage Δ
src/components/Slider/Slider.tsx 16.00% <13.04%> (-41.15%) ⬇️
src/components/Slider/style.ts 50.00% <44.44%> (-10.00%) ⬇️
src/components/Slider/index.ts 100.00% <100.00%> (ø)
src/helpers/border.ts 100.00% <100.00%> (ø)
src/helpers/color.ts 93.33% <100.00%> (ø)
src/helpers/elevations.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3995ebd...660fa1b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants