Allow to fill in the user timezone and related fixes #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHoaro
reviewed
Sep 5, 2021
| @@ -43,3 +43,49 @@ | |||
| <input type="hidden" name="tags_separator" value="{$tags_separator}" id="tags_separator" /> | |||
|
|
|||
| <script src="{$asset_path}/js/shaarli.min.js?v={$version_hash}#"></script> | |||
| <script> | |||
There was a problem hiding this comment.
A few pointers:
- Your JS code needs to be shared in a single file in https://github.com/shaarli/Shaarli/tree/master/assets/common/js/, then generated for both templates here and here. This way you can include your JS file in templates file that are using a timezone selector instead of the footer (aka each pages).
- It will need to follow our ESLint rules.
- Use full words instead of abbreviation as much as possible to make it more readable.
There was a problem hiding this comment.
@yfdyh000 will you have the time to implement the requested changes? There is no rush, but this PR has been sitting since 2021, should we keep it open?
ArthurHoaro
added
ergonomy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a button to quickly fill in the time zone from the user browser / system.
It also solves a problem, the cities list will not update while the second time selection of any continent.
Unresolved:
Ugly coding. No code sharing (reuse).