Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields not showing up properly for overlay #535

Closed
bhajneet opened this issue May 17, 2020 · 4 comments · Fixed by #551
Closed

Fields not showing up properly for overlay #535

bhajneet opened this issue May 17, 2020 · 4 comments · Fixed by #551
Assignees
@Harjot1Singh
Labels
Effort 1 Simple task (code/non-code). ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@bhajneet
Copy link
Member

If english translation is on and refreshing example overlay sometimes the english doesn't show up and you can make it show up by toggling off/on in settings (or refreshing enough times maybe)
@bhajneet bhajneet added Status: To Do ○ Type Bug Regressions/production issues that do not function as intended. Effort 1 Simple task (code/non-code). labels May 17, 2020
@Harjot1Singh
Copy link
Member

Reproduced by setting network to fast 3g

@Harjot1Singh
Copy link
Member

https://github.com/ShabadOS/desktop/blob/dev/app/frontend/src/App.js#L89

This thing. Causes a race condition, since without setState, does not let react now the settings have updated.

@Harjot1Singh
Copy link
Member

Reproduced on presenter too with the same conditions.

@Harjot1Singh
Copy link
Member

TTR: 15mins

Harjot1Singh added a commit to Harjot1Singh/presenter that referenced this issue May 24, 2020
@Harjot1Singh
fix(frontend): reload settings when default options have been modified
c3ec71a 
Closes shabados#535
@Harjot1Singh Harjot1Singh mentioned this issue May 24, 2020
Merged
@bhajneet bhajneet mentioned this issue May 30, 2020
Open
@saihaj saihaj mentioned this issue Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Harjot1Singh Harjot1Singh

Labels
Effort 1 Simple task (code/non-code). ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend): reload settings when default options have been modified Harjot1Singh/presenter
2 participants
@Harjot1Singh @bhajneet